[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Delayed loading of image libraries
From: |
Juanma Barranquero |
Subject: |
Re: [PATCH] Delayed loading of image libraries |
Date: |
Wed, 30 Jun 2004 13:13:25 +0200 |
On Wed, 30 Jun 2004 12:15:29 +0200
Andreas Schwab <address@hidden> wrote:
> Please make libraries an explicit parameter of CHECK_LIB_AVAILABLE, so
> that it does not look like it is completely ignored.
Well, it is a matter of taste. Hidding things is not good, but
redundant info is not good either, and in this case, there's no way
CHECK_LIB_AVAILABLE is ever gonna get passed anything but `libraries'.
Also, CHECK_LIB_AVAILABLE is defined just above init-image-library; it
takes only a cursory look to notice that `libraries' is being used. I'd
agree with you if CHECK_LIB_AVAILABLE were defined in an include file,
or at the top of image.c.
> Also, you are
> missing to declare the parameters.
You're right; thanks for noticing.
> Please always compile with -Wall.
I'll try to remember, if I ever compile with GCC. For MSVC, I'm using
the default warnings (default, as set up by nt/configure.bat, I mean);
with these, there's no warning for the missing parameter declarations.
Juanma