Re: CVS Emacs list-buffer-noselect calls set-window-buffer, displays every buffer briefly!

[Stephan Stahl]

(I did not include emacs-develand the others in my reply..
so here it goes again)

Hi Francis.

Francis Litterio said:

> RMS's patch adds a BUFFER argument to format-mode-line, which makes it
> possible to avoid calling set-window-buffer in list-buffers-noselect, as
> follows:
>
> --- buff-menu.el        02 Sep 2004 10:36:13 -0400        1.67
> +++ buff-menu.el        08 Sep 2004 14:32:06 -0400
> @@ -641,10 +641,10 @@
>                         (save-window-excursion
>                           (setq name (buffer-name)
>                                 mode (progn
> -                                      (set-window-buffer (selected-window) 
> buffer)
> -                                      (concat (format-mode-line mode-name)
> +                                      (concat (format-mode-line mode-name 
> nil nil buffer)
>                                                (if mode-line-process
> -                                                  (format-mode-line 
> mode-line-process))))
> +                                                  (format-mode-line 
> mode-line-process nil nil
> +                                                                    
> buffer))))
>                                 file (buffer-file-name)))
>                         (cond
>                          ;; Don't mention internal buffers.

Could you please try to verify if this really works?  I tried the same
thing but i did not get the right results.  My testcase was M-x shell,
M-x rename-uniquely, M-x shell, exit.  Now i have two shell buffers,
one running, one not. C-x C-b from the running shell adds ":run" to
both buffers in the buffer-list. The same thing from the finished
shell adds ":exit [0]" to both.  I have not found time to take a
closer look at why Richards patch does not seem to work for me.  And
yes i applied Richards patch and recompiled emacs ;-).

Oh with this simpler patch the progn could be omitted.

Stephan
-- 
Stephan Stahl