emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: defconst in lao.el


From: Luc Teirlinck
Subject: Re: defconst in lao.el
Date: Sun, 14 Nov 2004 15:47:56 -0600 (CST)

Stefan Monnier wrote:

   > @@ -42,7 +42,7 @@
   >      (compose-string (quail-lookup-map-and-concat quail-current-key))))
   >    control-flag)
   >  
   > -(defconst lao-key-alist
   > +(defvar lao-key-alist
   >    '(("!" . "1")
   >      ("\"" . "=")
   >      ("#" . "3")

   This one also looks wrong: this is treated as a constant as far as
   I can tell.

This is again difficult to say, since for all related variables the
defconst was clearly wrong.  It indeed is less clear for this one and
it produces no compiler warnings.  Again, I will _keep_ the defconst,
to err on the consevative side in terms of making changes to code that
I am not really terribly familiar with.

Sincerely,

Luc.
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]