emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: interactive-p fix for table.el


From: Richard Stallman
Subject: Re: interactive-p fix for table.el
Date: Wed, 17 Nov 2004 00:04:00 -0500

In cases where it only controls a message, as here,

                   (setq cells (1- cells))
                   (and (> n 0) (> cells 0)))))
          (table-recognize-cell 'force)
    !     (if (interactive-p)
            (message "Sequencing...done"))
          ))

it is ok to use interactive-p.

In some cases, both the old code and the new code must be wrong.
For instance,

    ***************
    *** 5346,5352 ****
      This feature is disabled when `table-disable-incompatibility-warning'
      is non-nil.  The warning is done only once per session for each item."
        (unless (and table-disable-incompatibility-warning
    !          (not (interactive-p)))
          (cond ((and (featurep 'xemacs)
                    (not (get 'table-disable-incompatibility-warning 'xemacs)))
               (put 'table-disable-incompatibility-warning 'xemacs t)
    --- 5353,5359 ----
      This feature is disabled when `table-disable-incompatibility-warning'
      is non-nil.  The warning is done only once per session for each item."
        (unless (and table-disable-incompatibility-warning
    !          (not (called-interactively-p)))
          (cond ((and (featurep 'xemacs)
                    (not (get 'table-disable-incompatibility-warning 'xemacs)))
               (put 'table-disable-incompatibility-warning 'xemacs t)

Since this function is not interactive, both interactive-p and
called-interactively-p will always return nil in this function.
Whatever you want to do, you need to do it some other way.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]