Re: buff-menu.el header line

[Robert J. Chassell]

Your fixes (revision 1.73) to patch list-buffers-noselect to fit in 80
columns work OK for me.

As for the alignment patch, it works using today's CVS checkout of 
Fri, 2004 Nov 19  14:13 UTC, rebuilt with `bootfast'.

However, the intangible text property still needs to be changed.  
Converting that line to 

        (put-text-property 1 (point) 'fixed-pitch t))

looks OK to me.

Here are the two patches to your revision 1.73:


diff -rc2P /usr/local/src/emacs/lisp/buff-menu.el.\~1.73.\~ 
/usr/local/src/emacs/lisp/buff-menu.el
*** /usr/local/src/emacs/lisp/buff-menu.el.~1.73.~      Fri Nov 19 14:13:41 2004
--- /usr/local/src/emacs/lisp/buff-menu.el      Fri Nov 19 15:05:29 2004
***************
*** 654,658 ****
                         (Buffer-menu-make-sort-button "File" 5) "\n"))
         list desired-point)
!     (when Buffer-menu-use-header-line
        (let ((pos 0))
        ;; Turn spaces in the header into stretch specs so they work
--- 654,658 ----
                         (Buffer-menu-make-sort-button "File" 5) "\n"))
         list desired-point)
! ;;    (when Buffer-menu-use-header-line
        (let ((pos 0))
        ;; Turn spaces in the header into stretch specs so they work
***************
*** 663,667 ****
                             ;; Assume fixed-size chars
                             (list 'space :align-to (1- pos))
!                            header))))
      (with-current-buffer (get-buffer-create "*Buffer List*")
        (setq buffer-read-only nil)
--- 663,667 ----
                             ;; Assume fixed-size chars
                             (list 'space :align-to (1- pos))
!                            header))) ;; )
      (with-current-buffer (get-buffer-create "*Buffer List*")
        (setq buffer-read-only nil)
***************
*** 672,676 ****
        (insert (Buffer-menu-buffer+size "------" "----"))
        (insert "  ----" mode-end "----\n")
!       (put-text-property 1 (point) 'intangible t))
        (if buffer-list
          (setq list buffer-list)
--- 672,676 ----
        (insert (Buffer-menu-buffer+size "------" "----"))
        (insert "  ----" mode-end "----\n")
!       (put-text-property 1 (point) 'fixed-pitch t))
        (if buffer-list
          (setq list buffer-list)

Diff finished.  Fri Nov 19 15:10:31 2004


Another bug:  when Buffer-menu-use-header-line is set to nil, even
though a keybinding appears as an echo area `tip' when you move the
mouse over a header line position, Buffer-menu-mouse-select fails.

Buffer-menu-mouse-select should succeed.  

Stephan Stahl suggested sort commands that could be attached to
keybindings.  This makes sense.  This could be done after the release.
For example:

    C-c C-s C-b for sort-buffername
    C-c C-s C-s for sort-size
    C-c C-s C-m for sort-mode
    C-c C-s C-f for sort-file
    C-c C-s C-u for sort-unsorted

-- 
    Robert J. Chassell                         
    address@hidden                         GnuPG Key ID: 004B4AC8
    http://www.rattlesnake.com                  http://www.teak.cc