[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Hourglass only for X-windows?
From: |
Lennart Borgman |
Subject: |
Re: Hourglass only for X-windows? |
Date: |
Tue, 1 Mar 2005 01:17:04 +0100 |
----- Original Message -----
From: "Eli Zaretskii" <address@hidden>
> > From: "Lennart Borgman" <address@hidden>
> > I suggest removing the "#ifdef HAVE_X_WINDOWS" completely or (which I
> > believe most would like better - but not I) replacing them with
something
> > like
> >
> > #ifdef HAS_HOURGLASS
>
> We cannot do the former without adding (possibly empty) functions
> called by those snippets to all ports. And we cannot do the latter
> without adding some configury stuff that would determine the value of
> HAS_HOURGLASS at configure time.
>
> Personally, I think we are fine as we are now. Of course, if you
> implement start_hourglass et al for Windows, the HAVE_X_WINDOWS
> condition needs to be augmented by something that will enable it for
> Windows.
Yes, I thought I would implement start_hourglass etc. Maybe someone wants
to implement it in macfns.c too where the body part also has an empty body
part.
Whichever way of changing the current "#ifdef HAVE_X_WINDOWS" at those
places are enough, but removing the ifdef:s and adding a file with empty
body parts for those ports that does not implement hourglass support makes
the code easier to read IMO.