Re: syntax highlight fix for add-log.el

[Marcelo Toledo]

Richard Stallman <address@hidden> writes:

>         ;; File names.
>     !     ("^\\(?: \\{8\\}\\|\t\\)\\* \\([^ ,:([\n]+\\)"
>
> This seems to insist on 8 spaces.
> It can be any number of spaces; one space is enough.

Modified to work with 1 or more spaces.

>           (log-edit-previous-comment arg)
>     !       (indent-region (point-min) (point-max) nil)
>
> This change looks like a no-op.  What is the bug you intend to fix?

I was looking old code and old documentation where column was no
optional, sorry. Just ignore it.

I've installed this patch:

Index: lisp/ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.7247
diff -u -r1.7247 ChangeLog
--- lisp/ChangeLog      3 Apr 2005 21:26:11 -0000       1.7247
+++ lisp/ChangeLog      3 Apr 2005 22:44:25 -0000
@@ -1,3 +1,11 @@
+2005-04-03  Marcelo Toledo  <address@hidden>
+
+        * add-log.el (change-log-font-lock-keywords): The manual
+        describing a Change Log entry, says: (...) "Aside from these
+        header lines, every line in the change log starts with a space or
+        a tab.". The font-lock was not highlighting lines started with
+        spaces, added support for it.
+
 2005-04-03  Roland Winkler  <address@hidden>
 
        * textmodes/bibtex.el (bibtex-url): Use format to generate the url.
Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.156
diff -u -r1.156 add-log.el
--- lisp/add-log.el     21 Mar 2005 14:37:35 -0000      1.156
+++ lisp/add-log.el     3 Apr 2005 22:44:33 -0000
@@ -225,7 +225,7 @@
       (2 'change-log-email-face)))
     ;;
     ;; File names.
-    ("^\t\\* \\([^ ,:([\n]+\\)"
+    ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
      (1 'change-log-file-face)
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))

-- 
Marcelo Toledo
address@hidden
http://www.marcelotoledo.org
Mobile: 55 71 9116-1101