Re: font-lock-comment-delimiter-face

[Dan Nicolaescu]

Richard Stallman <address@hidden> writes:

  >     If the red colored comments are hard to read on a console, can't we
  >     just change the face foreground for font-lock-comment-face for that
  >     situation (i.e. min-colors == 8 and background-mode == 'dark)? 
  >     It seems to me that would be a lot easier than adding
  >     font-lock-comment-delimiter-face route? 
  > 
  > I am not entirely sure what you're proposing.
  > Could you be more specific?  I could try it out.

Your original complaint was that font-lock-comment-face that has
face-foreground "red" is hard to read on a console. I am proposing to
just change that "red" color to some other color that is readable on a
console.

  >     So just do M-x list-colors-display RET pick a color for comments and
  >     I'll do the needed change.
  > 
  > Please don't install such a change, but I'd appreciate it if you sent
  > me a patch to try.

I had no intention of installing a change without reaching some
consensus. That would not be wise given the amount of discussions
going on.

Please try this patch:

*** font-lock.el        20 May 2005 15:40:40 -0700      1.257
--- font-lock.el        21 May 2005 10:36:03 -0700      
***************
*** 1678,1686 ****
      (((class color) (min-colors 16) (background dark))
       (:foreground "red1"))
      (((class color) (min-colors 8) (background light))
!      )
      (((class color) (min-colors 8) (background dark))
!      )
      (t (:weight bold :slant italic)))
    "Font Lock mode face used to highlight comments."
    :group 'font-lock-highlighting-faces)
--- 1678,1691 ----
      (((class color) (min-colors 16) (background dark))
       (:foreground "red1"))
      (((class color) (min-colors 8) (background light))
!      ;; IMHO this should not have been changed, red is quite readable
!      ;; on a light background (e.g. xterm -bg white)
!      (:foreground "red"))
      (((class color) (min-colors 8) (background dark))
!      ;; Change the color here if you want to see how other colors
!      ;; look like for comments. 
!      ;; You can choose one of: black red green yellow blue magenta cyan white
!      (:foreground "yellow"))
      (t (:weight bold :slant italic)))
    "Font Lock mode face used to highlight comments."
    :group 'font-lock-highlighting-faces)
***************
*** 1689,1698 ****
    '((default :inherit font-lock-comment-face)
      (((class grayscale)))
      (((class color) (min-colors 16)))
!     (((class color) (min-colors 8) (background light))
!      :foreground "red")
!     (((class color) (min-colors 8) (background dark))
!      :foreground "red1"))
    "Font Lock mode face used to highlight comment delimiters."
    :group 'font-lock-highlighting-faces)
  
--- 1694,1705 ----
    '((default :inherit font-lock-comment-face)
      (((class grayscale)))
      (((class color) (min-colors 16)))
! ;; Commented out to disable the effects of font-lock-comment-delimiter-face
! ;;     (((class color) (min-colors 8) (background light))
! ;;      :foreground "red")
! ;;     (((class color) (min-colors 8) (background dark))
! ;;      :foreground "red1"))
!     )
    "Font Lock mode face used to highlight comment delimiters."
    :group 'font-lock-highlighting-faces)