emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trivial bug of font-lock in Change Log mode.


From: Kenichi Handa
Subject: Re: trivial bug of font-lock in Change Log mode.
Date: Fri, 10 Jun 2005 11:25:23 +0900
User-agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/22.0.50 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI)

In article <address@hidden>, Richard Stallman <address@hidden> writes:

>     Anyway, I think this kind of discussion is useless unless we
>     know what kind of date format we are going to support.  For
>     instance, the current one doesn't handle this kind of date
>     format (note "JST"):

>     Sat May 28 09:41:40 JST 2005

> The idea is to handle date formats that were actually used in change
> logs, now or in the past.  We don't want to aim to handle all date formats
> that people use in other contexts.

A user can use any kind of date formats in the context of
ChangeLog file by customizing add-log-time-format.

> I recall that we did previously use a different date format.
> I don't remember what it was, but maybe you can find it from
> old versions of add-log.el.

Yes, that's something like this:
Sat Jan  1 00:00:00 2000

If what you really mean is: "... handle the DEFAULT date
formats that were actually used in Emacs ...", I'd like to
install the attached patch.

---
Kenichi Handa
address@hidden

Index: add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.163
diff -c -r1.163 add-log.el
*** add-log.el  29 May 2005 16:09:04 -0000      1.163
--- add-log.el  10 Jun 2005 02:20:26 -0000
***************
*** 216,223 ****
  
  (defvar change-log-font-lock-keywords
    '(;;
!     ;; Date lines, new and old styles.
!     ("^\\sw.........[0-9:+ ]*"
       (0 'change-log-date-face)
       ;; Name and e-mail; some people put e-mail in parens, not angles.
       ("\\([^<(]+?\\)[ \t]*[(<]\\(address@hidden)[>)]" nil nil
--- 216,227 ----
  
  (defvar change-log-font-lock-keywords
    '(;;
!     ;; Date lines, new (2000-01-01) and old (Sat Jan  1 00:00:00 2000) styles.
!     ;; Fixme: this regepx is just an approximate one and may match
!     ;; wrongly with a non-date line existing as a random note.  In
!     ;; addition, using any kind of fixed setting like this doesn't
!     ;; work if a user customizes add-log-time-format.
!     ("^[0-9-]+ +\\|^\\(Sun\\|Mon\\|Tue\\|Wed\\|Thu\\|Fri\\|Sat\\) 
[A-z][a-z][a-z] [0-9:+ ]+"
       (0 'change-log-date-face)
       ;; Name and e-mail; some people put e-mail in parens, not angles.
       ("\\([^<(]+?\\)[ \t]*[(<]\\(address@hidden)[>)]" nil nil




reply via email to

[Prev in Thread] Current Thread [Next in Thread]