emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: url-retrieve bad handling of redirections


From: Richard M. Stallman
Subject: Re: url-retrieve bad handling of redirections
Date: Fri, 01 Jul 2005 00:03:49 -0400

        Adding a new parameter to the callback routine so that it still can 
have 
        the original outfile as a parameter. That way you could continue from 
        the redirect and change the redirected url instead of the original.

What do you think of this change?
Unfortunately it is not practical for me to study the code enough
to tell if this would break anything.

*** url-http.el 28 Jun 2005 17:36:57 -0400      1.16
--- url-http.el 30 Jun 2005 20:59:56 -0400      
***************
*** 501,508 ****
                 (url-request-data url-http-data)
                 (url-request-extra-headers url-http-extra-headers))
             (url-retrieve redirect-uri url-callback-function
!                          (cons redirect-uri
!                                (cdr url-callback-arguments)))
             (url-mark-buffer-as-dead (current-buffer))))))
        (4                              ; Client error
         ;; 400 Bad Request
--- 501,509 ----
                 (url-request-data url-http-data)
                 (url-request-extra-headers url-http-extra-headers))
             (url-retrieve redirect-uri url-callback-function
!                          (cons :redirect
!                                (cons redirect-uri
!                                      url-callback-arguments)))
             (url-mark-buffer-as-dead (current-buffer))))))
        (4                              ; Client error
         ;; 400 Bad Request




reply via email to

[Prev in Thread] Current Thread [Next in Thread]