[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: optimization for pop movemail
|
From: |
Richard M. Stallman |
|
Subject: |
Re: optimization for pop movemail |
|
Date: |
Mon, 04 Jul 2005 12:48:32 -0400 |
Thanks for noticing this issue.
+ if (line == pop_error && strlen (line) < sizeof (pop_error) - 5)
That code is a horrible kludge. It would be better to copy the string
to a temporary buffer and add the \r\n there. You could allocate it
with alloca. That is clean, and you could do it unconditionally.
This may as well be fixed now--why wait?