Re: Code inspection: W32 specific problems

[David Hunter]

Eli Zaretskii wrote:
> As for Qw32_charset_default and Vx_hand_shape, someone with more
> knowledge in the w32 code than myself should look at this.

The declaration for Vx_hand_shape may be removed.

Qw32_charset_default was declared in w32term.c rev 1.62 in early 2000, but was 
not defined there either.  It is potentially used by several codepaths, notably 
in enum_font_cb2().  The related symbol 'w32-charset-default' also exists in 
documentation.  It should be defined.

Here's a patch.

-Dave


*** w32fns.c    4 Jul 2005 16:06:36 -0000       1.253
--- w32fns.c    16 Jul 2005 17:13:46 -0000
***************
*** 153,159 ****
     over text or in the modeline.  */
  
  Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape;
! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape, 
Vx_hand_shape;
  
  /* The shape when over mouse-sensitive text.  */
  
--- 153,159 ----
     over text or in the modeline.  */
  
  Lisp_Object Vx_pointer_shape, Vx_nontext_pointer_shape, Vx_mode_pointer_shape;
! Lisp_Object Vx_hourglass_pointer_shape, Vx_window_horizontal_drag_shape;
  
  /* The shape when over mouse-sensitive text.  */
  
***************
*** 8760,8765 ****
--- 8760,8767 ----
    staticpro (&Qw32_charset_ansi);
    Qw32_charset_ansi = intern ("w32-charset-ansi");
    staticpro (&Qw32_charset_symbol);
+   Qw32_charset_default = intern ("w32-charset-default");
+   staticpro (&Qw32_charset_default);
    Qw32_charset_symbol = intern ("w32-charset-symbol");
    staticpro (&Qw32_charset_shiftjis);
    Qw32_charset_shiftjis = intern ("w32-charset-shiftjis");