Re: Mode line faces on ttys

[Juri Linkov]

While looking at inverse-related functions , I noticed that there are
two duplicate functions in faces.el: `set-face-underline' and
`set-face-underline-p'.  Since `set-face-underline-p' is documented in
the manual, so I assume that the correct name is `set-face-underline-p'.

The patch below deletes the function `set-face-underline' (with moving
its docstring to the `set-face-underline-p', because the docstring
of `set-face-underline' is more complete), and replaces
`set-face-underline' with an alias to `set-face-underline-p'.

Index: lisp/faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.333
diff -c -r1.333 faces.el
*** lisp/faces.el       6 Aug 2005 22:13:42 -0000       1.333
--- lisp/faces.el       17 Aug 2005 16:29:34 -0000
***************
*** 770,776 ****
    (set-face-attribute face frame :stipple (or stipple 'unspecified)))
  
  
! (defun set-face-underline (face underline &optional frame)
    "Specify whether face FACE is underlined.
  UNDERLINE nil means FACE explicitly doesn't underline.
  UNDERLINE non-nil means FACE explicitly does underlining
--- 770,776 ----
    (set-face-attribute face frame :stipple (or stipple 'unspecified)))
  
  
! (defun set-face-underline-p (face underline-p &optional frame)
    "Specify whether face FACE is underlined.
  UNDERLINE nil means FACE explicitly doesn't underline.
  UNDERLINE non-nil means FACE explicitly does underlining
***************
*** 781,800 ****
    (interactive
     (let ((list (read-face-and-attribute :underline)))
       (list (car list) (eq (car (cdr list)) t))))
-   (set-face-attribute face frame :underline underline))
- 
- 
- (defun set-face-underline-p (face underline-p &optional frame)
-   "Specify whether face FACE is underlined.
- UNDERLINE-P nil means FACE explicitly doesn't underline.
- UNDERLINE-P non-nil means FACE explicitly does underlining.
- FRAME nil or not specified means change face on all frames.
- Use `set-face-attribute' to ``unspecify'' underlining."
-   (interactive
-    (let ((list (read-face-and-attribute :underline)))
-      (list (car list) (eq (car (cdr list)) t))))
    (set-face-attribute face frame :underline underline-p))
  
  
  (defun set-face-inverse-video-p (face inverse-video-p &optional frame)
    "Specify whether face FACE is in inverse video.
--- 781,791 ----
    (interactive
     (let ((list (read-face-and-attribute :underline)))
       (list (car list) (eq (car (cdr list)) t))))
    (set-face-attribute face frame :underline underline-p))
  
+ (define-obsolete-function-alias 'set-face-underline
+                                 'set-face-underline-p "22.1")
+ 
  
  (defun set-face-inverse-video-p (face inverse-video-p &optional frame)
    "Specify whether face FACE is in inverse video.

-- 
Juri Linkov
http://www.jurta.org/emacs/