emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grep-use-null-device


From: Juri Linkov
Subject: Re: grep-use-null-device
Date: Tue, 30 Aug 2005 01:43:48 +0300
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>>     Thanks for posting the URL, though it seems that the web interface at
>>     lists.gnu.org eats multiple spaces.  Here is the Gmane URL for the
>>     original post from Kevin Rodgers with correct indentation:
>> 
>>        http://article.gmane.org/gmane.emacs.devel/33146
>> 
>> Can someone please install it?
>
> Done.

With this change, when grep finishes too quickly (for example, after
searching in a nonexistent file), `process-send-eof' fails with the
following error:

Debugger entered--Lisp error: (error "Process grep not running")
  process-send-eof(#<process grep>)
  compilation-start("grep -inH -e search file" grep-mode nil nil)
  grep("grep -inH -e search file")
  call-interactively(grep)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

`compilation-start' needs to check if the process is running
before calling `process-send-eof':

Index: lisp/progmodes/compile.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v
retrieving revision 1.378
diff -c -r1.378 compile.el
*** lisp/progmodes/compile.el   27 Aug 2005 14:38:21 -0000      1.378
--- lisp/progmodes/compile.el   29 Aug 2005 22:18:30 -0000
***************
*** 1032,1038 ****
                                                       outbuf command))))
              ;; Make the buffer's mode line show process state.
              (setq mode-line-process '(":%s"))
!             (when compilation-disable-input
                (process-send-eof proc))
              (set-process-sentinel proc 'compilation-sentinel)
              (set-process-filter proc 'compilation-filter)
--- 1032,1039 ----
                                                       outbuf command))))
              ;; Make the buffer's mode line show process state.
              (setq mode-line-process '(":%s"))
!             (when (and compilation-disable-input
!                        (eq (process-status proc) 'run))
                (process-send-eof proc))
              (set-process-sentinel proc 'compilation-sentinel)
              (set-process-filter proc 'compilation-filter)

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]