emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Enhanced enhanced visual feedback in `*Completions*' buffer


From: Masatake YAMATO
Subject: Re: Enhanced enhanced visual feedback in `*Completions*' buffer
Date: Sun, 09 Oct 2005 13:16:10 +0900 (JST)

> The feature seems like a natural generalization of the existing
> feature, but
> 
>     I introduce a variable, `completion-common-string' which is used as a
>     hint in `completion-setup-function' to put faces to *Completions*
>     buffer. Client code like `lisp-complete-symbol' sets
>     `completion-common-string'.
> 
> is somewhat of a pain in the neck.  And it would need to be documented
> in NEWS and the Lisp manual.

Yes, it would need.

> Have you found all the functions in Emacs that would need to be changed?

Not yet. I may have to check all the place where `display-completion-list' 
is used.

> Is this variable the best API for it?  Would it be better
> to add an optional argument to display-completion-list?

What you wrote is much beter. 
I'll rewrite my patch.

Thank you for reviwing.
Masatake YAMATO




reply via email to

[Prev in Thread] Current Thread [Next in Thread]