Re: address@hidden: Re: mode-line redisplay bug]

[Kim F. Storm]

YAMAMOTO Mitsuharu <address@hidden> writes:

>>>>>> On Wed, 12 Oct 2005 13:47:58 +0200 (CEST), David PONCE <address@hidden> 
>>>>>> said:
>
>> Oops I spoke too fast.  Now I get the following message when the
>> mouse is over the read-only/modified status characters on the
>> mode-line:
>
>> Error during redisplay: (wrong-type-argument window-live-p nil) [126
>> times]
>
> Sorry.  I've been using the patch for a long time, but I didn't notice
> that.  The last change was backed out.

I think your change was pretty close to being ok.  Here is something
which seems to work for me on X -- maybe you can install it and adapt
it to W32 and MAC if it works for you too.

*** xterm.c     12 Oct 2005 14:42:03 +0200      1.883
--- xterm.c     12 Oct 2005 15:26:41 +0200      
***************
*** 3582,3588 ****
  static XMotionEvent last_mouse_motion_event;
  static Lisp_Object last_mouse_motion_frame;
  
! static void
  note_mouse_movement (frame, event)
       FRAME_PTR frame;
       XMotionEvent *event;
--- 3582,3588 ----
  static XMotionEvent last_mouse_motion_event;
  static Lisp_Object last_mouse_motion_frame;
  
! static int
  note_mouse_movement (frame, event)
       FRAME_PTR frame;
       XMotionEvent *event;
***************
*** 3596,3605 ****
        frame->mouse_moved = 1;
        last_mouse_scroll_bar = Qnil;
        note_mouse_highlight (frame, -1, -1);
      }
  
    /* Has the mouse moved off the glyph it was on at the last sighting?  */
!   else if (event->x < last_mouse_glyph.x
           || event->x >= last_mouse_glyph.x + last_mouse_glyph.width
           || event->y < last_mouse_glyph.y
           || event->y >= last_mouse_glyph.y + last_mouse_glyph.height)
--- 3596,3606 ----
        frame->mouse_moved = 1;
        last_mouse_scroll_bar = Qnil;
        note_mouse_highlight (frame, -1, -1);
+       return 1;
      }
  
    /* Has the mouse moved off the glyph it was on at the last sighting?  */
!   if (event->x < last_mouse_glyph.x
           || event->x >= last_mouse_glyph.x + last_mouse_glyph.width
           || event->y < last_mouse_glyph.y
           || event->y >= last_mouse_glyph.y + last_mouse_glyph.height)
***************
*** 3609,3615 ****
--- 3610,3619 ----
        note_mouse_highlight (frame, event->x, event->y);
        /* Remember which glyph we're now on.  */
        remember_mouse_glyph (frame, event->x, event->y, &last_mouse_glyph);
+       return 1;
      }
+ 
+   return 0;
  }
  
  
***************
*** 6483,6490 ****
      case MotionNotify:
        {
          previous_help_echo_string = help_echo_string;
!         help_echo_string = help_echo_object = help_echo_window = Qnil;
!         help_echo_pos = -1;
  
          if (dpyinfo->grabbed && last_mouse_frame
              && FRAME_LIVE_P (last_mouse_frame))
--- 6487,6493 ----
      case MotionNotify:
        {
          previous_help_echo_string = help_echo_string;
!         help_echo_string = Qnil;
  
          if (dpyinfo->grabbed && last_mouse_frame
              && FRAME_LIVE_P (last_mouse_frame))
***************
*** 6523,6529 ****
  
                  last_window=window;
                }
!             note_mouse_movement (f, &event.xmotion);
            }
          else
            {
--- 6526,6533 ----
  
                  last_window=window;
                }
!             if (!note_mouse_movement (f, &event.xmotion))
!             help_echo_string = previous_help_echo_string;
            }
          else
            {

-- 
Kim F. Storm <address@hidden> http://www.cua.dk