emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bookmarks / switch-to-buffer


From: David Reitter
Subject: bookmarks / switch-to-buffer
Date: Thu, 10 Nov 2005 00:49:15 +0000

The function `bookmark-jump' failed to work in my environment, where switch-to-buffer is advised.

The reason was that bookmark-jump expects switch-to-buffer to return a non-nil value (if succeeded), but switch-to-buffer is not actually documented to do so.

Therefore I'd suggest to ignore the return value of switch-to-buffer in bookmark's bookmark-jump function. This fixed the problem for me.

*** bookmark.el 19 Oct 2005 09:45:43 -0000      1.84
--- bookmark.el 10 Nov 2005 00:46:21 -0000
***************
*** 1062,1068 ****
    (bookmark-maybe-historicize-string bookmark)
    (let ((cell (bookmark-jump-noselect bookmark)))
      (and cell
!          (switch-to-buffer (car cell))
           (goto-char (cdr cell))
         (progn (run-hooks 'bookmark-after-jump-hook) t)
         (if bookmark-automatically-show-annotations
--- 1062,1068 ----
    (bookmark-maybe-historicize-string bookmark)
    (let ((cell (bookmark-jump-noselect bookmark)))
      (and cell
!          (or (switch-to-buffer (car cell)) t)
           (goto-char (cdr cell))
         (progn (run-hooks 'bookmark-after-jump-hook) t)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]