savehist-mode: invalid-read-syntax "#"

[Reiner Steib]

Hi,

`savehist-mode' is a very nice new feature in Emacs 22.  I like it
very much.  Thanks, Hrvoje!

Alas, from time to time `savehist-mode' saves entries containing "#"
like...

  (setq command-history '((describe-key '[(mouse-6 (#<window 14 on
  site-start.el> 41046 (293 . 354) 5470111 nil 41046 (48 . 27)
  nil (221 . 3) (6 . 13)))] 1 nil)))

... to `~/.emacs.d/history'.  The mouse-6 entry came from using `C-h
k'.  I've also seen offending entries after using "#" in with `M-!'
(shell-command-history).  When starting Emacs next, I got...

Debugger entered--Lisp error: (invalid-read-syntax "#")
  signal(invalid-read-syntax ("#"))
  byte-code("STRIPPED" [savehist-mode errvar nil savehist-uninstall signal] 3)
  savehist-mode(nil)
  call-interactively(savehist-mode)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)

Probably `savehist-mode' shouldn't try to save describe-key entries in
the first place.  And it should try to make sure that the history file
is syntactically correct.

Bye, Reiner.


Version  information follows...

In GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.4.9)
 of 2005-12-29 on shrubbery
X server distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure '--prefix=/import/xtra/emacs/HEAD' '--with-gtk' 
'--exec-prefix=/import/xtra/emacs/HEAD-i686''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: POSIX
  value of $LC_CTYPE: address@hidden
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: iso-8859-15
  default-enable-multibyte-characters: t

Major mode: Message

Minor modes in effect:
  flyspell-mode: t
  mml-mode: t
  iswitchb-mode: t
  msb-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  show-paren-mode: t
  which-function-mode: t
  recentf-mode: t
  tooltip-mode: t
  auto-compression-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-decoding-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: identity
  abbrev-mode: t