Re: mouse.el patch for region tracking

[JD Smith]

On Jan 3, 2006, at 8:37 AM, Stefan Monnier wrote:

> > > I have a question about this part: why do you not delete the  
> > > overlay when
> > > transient-mark-mode is active?
>
> > I guess because the region is still active, so, as normally in
> > transient-mark-mode, the active region should remain highlighted  
> > until mark
> > is deactivated, just as in normal selection.
>
> The region highlighting (when transient-mark-mode is ON) is not  
> done by
> mouse-region-overlay, so deleting this overlay shouldn't make
> any difference.
>
> > Maybe this isn't necessary.
>
> Indeed AFAICT it shouldn't be necessary, which is why I ask.
> If the explicit test is placed there only based on a fear of what  
> might
> happen, rather than on actual evidence, then I suggest to remove it.

The evidence is that, when transient-mark-mode is bound, as:

(defun do-drag (event)
  (interactive "e")
  (let ((transient-mark-mode t))
    (message "DRAG STARTED")
    (mouse-drag-track event)
    (message "DRAG FINISHED")))

the overlay is deleted anyway.  If transient mark mode is on outside  
of the let, everything behaves normally.  This is likely the correct  
behavior.  I've made this and the other changes you suggested, and  
checked them in.

Thanks,

JD