[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: mh-e/mh-acros.el advices `require' incorrectly
From: |
Drew Adams |
Subject: |
RE: mh-e/mh-acros.el advices `require' incorrectly |
Date: |
Fri, 13 Jan 2006 13:04:15 -0800 |
> The origianl `require' returns FEATURE even if it is already
> provided, but the adviced `require' returns nil in such a
> case. So, once mh-acros.el is loaded, a code depending on
> the return value of `require' stops working.
>
> How about this change?
What do you (and others) think about this?
Besides the fact that we shouldn't use defadvice in vanilla Emacs code, I
don't think we should change the return value of `require' at all. It has
acted this way for a very long time, and there is undoubtedly code that
depends on this behavior (at least some external libraries). Besides, we
certainly should not make such a change just before a release.
- mh-e/mh-acros.el advices `require' incorrectly, Kenichi Handa, 2006/01/13
- Re: mh-e/mh-acros.el advices `require' incorrectly, Bill Wohler, 2006/01/13
- RE: mh-e/mh-acros.el advices `require' incorrectly,
Drew Adams <=
- Re: mh-e/mh-acros.el advices `require' incorrectly, Kenichi Handa, 2006/01/13
- Re: mh-e/mh-acros.el advices `require' incorrectly, Richard M. Stallman, 2006/01/14
- Re: mh-e/mh-acros.el advices `require' incorrectly, Bill Wohler, 2006/01/14
- Re: mh-e/mh-acros.el advices `require' incorrectly, Andreas Schwab, 2006/01/14
- Re: mh-e/mh-acros.el advices `require' incorrectly, Bill Wohler, 2006/01/14
- Re: mh-e/mh-acros.el advices `require' incorrectly, Stefan Monnier, 2006/01/14
- Re: mh-e/mh-acros.el advices `require' incorrectly, Richard M. Stallman, 2006/01/15