emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: thumbs.el and transparency


From: Juri Linkov
Subject: Re: thumbs.el and transparency
Date: Sun, 12 Feb 2006 19:47:08 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

>> tumme.el is larger than most Lisp source files, but quite a few
>> are larger.  If you want to split it into 2 or 3 files, please do.
>> But only do that if you feel that makes it clearer and more
>> maintainable.
>
> 570+ lines are Commentary and History

You can remove History without any doubt.  This is the first thing that
is usually done after importing a new package into Emacs CVS.

> but yes, it has 2000+ lines of code which is quite much. I will think
> about a split, see if there are things that could be moved to make it
> easier to maintain, but I don't see it as an urgent thing to do
> right now.

What is needed to make tumme.el more maintainable right now is regrouping
functions and variables related to separate functionalities within one file.
Currently many related functions and variables are littered to different
parts of tumme.el.  The standard way to group related code is like below:

^L

;;; Generate gallery

(defcustom tumme-gallery-dir ...

(defcustom tumme-gallery-hidden-tags ...

... other gallery user options

... gallery internal variables

...

(defun tumme-gallery-generate ()
...

... other gallery commands

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]