[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make bootstrap: need moral support. :-(
From: |
Giorgos Keramidas |
Subject: |
Re: make bootstrap: need moral support. :-( |
Date: |
Wed, 22 Feb 2006 12:54:22 +0200 |
On 2006-02-22 11:30, Francesco Potorti` <address@hidden> wrote:
> >===================================================================
> >--- emacs/lib-src/etags.c (.../branches/gnu) (revision 26)
> >+++ emacs/lib-src/etags.c (.../trunk) (revision 26)
> >@@ -414,8 +414,8 @@
> > static void canonicalize_filename __P((char *));
> > static void linebuffer_init __P((linebuffer *));
> > static void linebuffer_setlen __P((linebuffer *, int));
> >-static PTR xmalloc __P((unsigned int));
> >-static PTR xrealloc __P((char *, unsigned int));
> >+PTR xmalloc __P((unsigned int));
> >+PTR xrealloc __P((char *, unsigned int));
> >
> >
> > static char searchar = '/'; /* use /.../ searches */
> >@@ -6864,7 +6864,7 @@
> > }
> >
> > /* Like malloc but get fatal error if memory is exhausted. */
> >-static PTR
> >+PTR
> > xmalloc (size)
> > unsigned int size;
> > {
> >@@ -6874,7 +6874,7 @@
> > return result;
> > }
> >
> >-static PTR
> >+PTR
> > xrealloc (ptr, size)
> > char *ptr;
> > unsigned int size;
> >%%%
>
> This patch is harmless, from the etags point of view. The choice for
> "static" was of theoretical cleanness and source documentation, but
> involved no practical issues.
>
> If you need that patch, I can apply it myself (I am the etags
> maintainer) or you can apply it, if you like it better. Just let me
> know.
No, that's fine. Thanks for the offer. The patch was only needed while
regex.c used xmalloc/xrealloc. Now that the change is reverted, I've
locally reverted this patch from my tree too.
Again, thanks :)
- Re: make bootstrap: need moral support. :-(, (continued)
Re: make bootstrap: need moral support. :-(, Richard M. Stallman, 2006/02/20
Re: make bootstrap: need moral support. :-(, Francesco Potorti`, 2006/02/22
- Re: make bootstrap: need moral support. :-(,
Giorgos Keramidas <=