Re: Cursor in non-selected windows is 1 pixel too small

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 04 Mar 2006 23:19:40 +0100, address@hidden (Kim F. Storm) said:

>> Is it possible that this problem is not specific to MS-Windows?

> I believe it works for X, fails for w32, and ... MAC?

Also works for Mac, because some adjustment is made in the drawing
routine mac_draw_rectangle (in macterm.c) so it simulates
XDrawRectangle.

  SetRect (&r, x, y, x + width + 1, y + height + 1);
  FrameRect (&r);

By the way, Quartz 2D (as opposed to QuickDraw above) needs another
kind of adjustment to get the same result:

  CGContextStrokeRect (context,
                       CGRectMake (x + 0.5f, y + 0.5f, width, height));

> However, it does seem to make sense to fix the height returned by
> get_phys_cursor_geometry (don't subtract 1), and then fix the use in
> xterm.c and macterm.c(?) to subtract 1 from the returned height.
> (and leave w32termc. as is).

The W32 port seems to have an adjustment for the cursor width in
get_phys_cursor_geometry:

  wd = glyph->pixel_width - 1;
#ifdef HAVE_NTGUI
  wd++; /* Why? */
#endif

So, wherever we add adjustment, it should be done in a consistent way
between width and height, I think.

                                     YAMAMOTO Mitsuharu
                                address@hidden