emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Please review: Small fix for window.c


From: Kim F. Storm
Subject: Please review: Small fix for window.c
Date: Wed, 08 Mar 2006 16:52:54 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Since any non-nil value for set-window-dedicated-p means window
is dedicated, testing explicitly for Qt seems like a bug...


*** window.c    28 Feb 2006 16:57:34 +0100      1.537
--- window.c    08 Mar 2006 16:49:11 +0100      
***************
*** 2009,2015 ****
               `obj & 1' means consider only full-width windows.
               `obj & 2' means consider also dedicated windows. */
            if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w))
!               || (!(XINT (obj) & 2) && EQ (w->dedicated, Qt))
                /* Minibuffer windows are always ignored.  */
                || MINI_WINDOW_P (w))
              break;
--- 2009,2015 ----
               `obj & 1' means consider only full-width windows.
               `obj & 2' means consider also dedicated windows. */
            if (((XINT (obj) & 1) && !WINDOW_FULL_WIDTH_P (w))
!               || (!(XINT (obj) & 2) && !NILP (w->dedicated))
                /* Minibuffer windows are always ignored.  */
                || MINI_WINDOW_P (w))
              break;
***************
*** 2064,2070 ****
          case GET_LARGEST_WINDOW:
            { /* nil `obj' means to ignore dedicated windows.  */
              /* Ignore dedicated windows and minibuffers.  */
!             if (MINI_WINDOW_P (w) || (NILP (obj) && EQ (w->dedicated, Qt)))
                break;
  
              if (NILP (best_window))
--- 2064,2070 ----
          case GET_LARGEST_WINDOW:
            { /* nil `obj' means to ignore dedicated windows.  */
              /* Ignore dedicated windows and minibuffers.  */
!             if (MINI_WINDOW_P (w) || (NILP (obj) && !NILP (w->dedicated)))
                break;
  
              if (NILP (best_window))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]