[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Problem report #50
From: |
Andreas Schwab |
Subject: |
Re: Problem report #50 |
Date: |
Mon, 10 Apr 2006 11:35:50 +0200 |
User-agent: |
Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) |
Dan Nicolaescu <address@hidden> writes:
> 428 /* Check in the home directory. This is a bit of a hack; let's
> 429 hope one's home directory doesn't contain any %-escapes. */
> 430 || (free_it = gethomedir (),
> 431 ((file = search_magic_path (free_it, class, "%L/%N", 0))
> 432 || (file = search_magic_path (free_it, class, "%N", 0)))))
> 433 {
> 434 XrmDatabase db = XrmGetFileDatabase (file);
> 435 free (file);
> 436 if (free_it)
> 437 free (free_it);
> 438 return db;
> 439 }
> 440
>
> Event check_after_deref: Pointer "free_it" dereferenced before NULL check
> Also see events: [deref_ptr_in_call]
This is wrong, since gethomedir always returns non-NULL (but not always a
heap pointer, which i've fixed now).
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."