emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: Backwards-compatible change to tq.el


From: Michael Olson
Subject: Re: RFC: Backwards-compatible change to tq.el
Date: Wed, 12 Apr 2006 16:58:20 -0400
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

"Stuart D. Herring" <address@hidden> writes:

> I don't know much about tq.el, but I'm leery of the line
>
> (tq-queue-add tq (and delay-question question) regexp closure fn)
>
> -- it seems to me that you want to include 'question' if and only if
> you aren't already sending it (because tq-queue-pop will definitely
> send it if you include it).  So shouldn't it be (unless sendp
> question) rather than (and delay-question question)?

Good catch.  I've fixed this in the attached patch.  I've also revised
the comments to include additional useful information.

Attachment: pgpmZ4vxbCb8m.pgp
Description: PGP signature

Attachment: tq.el.patch
Description: Text Data

-- 
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Interests: Emacs Lisp, text markup, protocols -- Muse, Planner, ERC, EMMS
  /` |\ | | | IRC: mwolson on freenode.net: #hcoop, #muse, #PurdueLUG
 |_] | \| |_| Jabber: mwolson_at_hcoop.net

reply via email to

[Prev in Thread] Current Thread [Next in Thread]