emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs unconditionally loads tramp.el


From: Michael Albinus
Subject: Re: Emacs unconditionally loads tramp.el
Date: Sat, 29 Apr 2006 21:55:39 +0200
User-agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (gnu/linux)

Richard Stallman <address@hidden> writes:

> I just found that this problem was due to XEmacs compatibility code.
> So I deleted that code.  I won't delete XEmacs compatibility code
> merely because it is XEmacs compatibility code; but I won't let
> a bug remain in Emacs for the sake of XEmacs.

Could we agree on this?

magdalene:~/src/emacs/lisp/net> cvs diff tramp.el
Index: tramp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/net/tramp.el,v
retrieving revision 1.95
diff -u -r1.95 tramp.el
--- tramp.el    29 Apr 2006 15:58:31 -0000      1.95
+++ tramp.el    29 Apr 2006 19:50:57 -0000
@@ -1931,9 +1931,14 @@
 ;; Handlers for partial tramp file names.  For Emacs just
 ;; `file-name-all-completions' is needed.
 (defconst tramp-completion-file-name-handler-alist
-  '(
-    (file-name-all-completions . 
tramp-completion-handle-file-name-all-completions)
-    (file-name-completion . tramp-completion-handle-file-name-completion))
+  (append
+   '((file-name-all-completions . 
tramp-completion-handle-file-name-all-completions)
+     (file-name-completion . tramp-completion-handle-file-name-completion))
+   (when (featurep 'xemacs)
+     '((file-name-directory . tramp-completion-handle-file-name-directory)
+       (file-name-nondirectory . 
tramp-completion-handle-file-name-nondirectory)
+       (file-exists-p . tramp-completion-handle-file-exists-p)
+       (expand-file-name . tramp-completion-handle-expand-file-name))))
   "Alist of completion handler functions.
 Used for file names matching `tramp-file-name-regexp'. Operations not
 mentioned here will be handled by `tramp-file-name-handler-alist' or the

> I also noticed this:
>
>     ; These values conform to `file-attributes' from XEmacs 21.2.
>     ; Emacs and other tools not checked.
>     (defconst tramp-file-mode-type-map
>
> What exactly hasn't been checked here?

Don't know, it was written before I've entered the Tramp team. I'll
check.

Best regards, Michael.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]