Re: should search ring contain duplicates?

[Eli Zaretskii]

> From: address@hidden (Kim F. Storm)
> Date: Sat, 06 May 2006 01:55:43 +0200
> Cc: address@hidden, address@hidden, address@hidden
> 
> Richard Stallman <address@hidden> writes:
> 
> > Please install add-to-history;
> > you can change places to use it, too.
> 
> Done.

I'm not sure I see the utility of the second optional argument
KEEP-DUPS.  It doesn't give you full control of whether the duplicates
are removed, unless you also bind history-delete-duplicates, so it's
not more convenient than simply binding history-delete-duplicates.
Its disadvantage, OTOH, albeit a minor one, is that it makes the doc
string harder to understand, due to multiple negations (``unless FOO
is nil or BAR is non-nil'').

Am I missing something?

(If you do change the function, please update the NEWS entry and the
Lisp manual where I added its description.)