emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes to emacs/src/ChangeLog


From: Kim F. Storm
Subject: Re: Changes to emacs/src/ChangeLog
Date: Mon, 08 May 2006 00:06:43 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

YAMAMOTO Mitsuharu <address@hidden> writes:

> +2006-05-06  YAMAMOTO Mitsuharu  <address@hidden>
> +
> +     * image.c (Qduration) [MAC_OS]: New variable.
> +     (syms_of_image) [MAC_OS]: Intern and staticpro it.
> +     [MAC_OS] (gif_load): Save image extension data in img->data.lisp_val.

The format you have chosen for the GIF extension data on MAC_OS is
completely different from the "raw" extension data which is returned for
other systems.  This makes it harder to use the data at the Lisp level.

Since it is trivial to emulate the "raw" format for the duration extension,
I would prefer if you do this, instead of using a different format.  E.g.:

unsigned char tem[4] = { 0, (duration)&0xff, ((duration)>>8)&0xff, 0 };

result = list4 (Qcount,
                make_number (images),
                make_number (0xF9),
                make_unibyte_string (tem, 4));
        

-- 
Kim F. Storm  http://www.cua.dk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]