Re: [PATCH] Unicode Lisp reader escapes

[Kenichi Handa]

In article <address@hidden>, Aidan Kehoe <address@hidden> writes:

>> Kevin Rodgers <address@hidden> writes:
>> 
>> > readcharfun is declared as a Lisp_Object in read1, so it should be
>> > possible to check it's type and only GCPRO when necessary.
>> 
>> I don't see any need to GCPRO readcharfun.  When called from Lisp the
>> arguments are already protected by being part of the call frame, and all
>> uses from C protect the object by other means (eg, by being put on
>> eval-buffer-list).

> That was my understanding of the code too. 

For instance, Fread is called from Fcall_interactively as
below:

                Lisp_Object tem;
[...]
                tem = Fread_from_minibuffer (build_string (callint_message),
                                             Qnil, Qnil, Qnil, Qnil, Qnil,
                                             Qnil, Qnil);
                if (! STRINGP (tem) || SCHARS (tem) == 0)
                  args[i] = Qnil;
                else
                  args[i] = Fread (tem);

In the calling sequence of
Fread->read_internal_start->read0->read1, I see no place
where the original `tem' is GCPROed.  Do I overlook
something?

---
Kenichi Handa
address@hidden