Re: Problem report #85

[Jan Djärv]

Dan Nicolaescu skrev:
> CID: 85
> Checker: USE_AFTER_FREE (help)
> File: base/src/emacs/src/fileio.c
> Function: Finsert_file_contents
> Description: Using freed pointer "conversion_buffer"
>
> Event freed_arg: Pointer "conversion_buffer" freed by function "xfree" [model]
> Also see events: [double_free][double_free][use_after_free][use_after_free]
>
> 4326              xfree (conversion_buffer);
> 4327              coding_free_composition_data (&coding);
>
> At conditional (1): "how_much == -1" taking false path
>
> 4328              if (how_much == -1)
> 4329                error ("IO error reading %s: %s",
> 4330                       SDATA (orig_filename), emacs_strerror (errno));
>
> At conditional (2): "how_much == -2" taking false path
>
> 4331              else if (how_much == -2)
> 4332                error ("maximum buffer size exceeded");
> 4333            }

If how_much < 0 (tested before the code snippet above), it must be -1, since 
that is what emacs_read may return.  So "how_much == -1" taking false path can 
not happen.  I don't see how how_much can become -2, so that code is probably 
dead (but harmless).

        Jan D.