Re: Problem report #33 RESOLVED

[Jan D.]

Dan Nicolaescu wrote:
> This one reappeared after the last xterm.c checkin.
> Is it OK not to check f for NULL here?
>   

No it is not OK.  If someone tries to get the widget tree with editres 
on an Emacs lucid dialog for example, Emacs will crash.  I've checked in 
a fix.

   Jan D.

> CID: 33
> Checker: NULL_RETURNS (help)
> File: base/src/emacs/src/xterm.c
> Function: handle_one_xevent
> Description: Dereferencing NULL value "f"
>
> 5801    #ifdef HACK_EDITRES
> 5802            if (event.xclient.message_type
> 5803                == dpyinfo->Xatom_editres)
> 5804              {
>
> Event returned_null: Function "x_any_window_to_frame" returned NULL value 
> (checked 8 out of 9 times) [model]
> Event var_assigned: Variable "f" assigned to NULL return value from 
> "x_any_window_to_frame"
> Also see events: [var_assigned][dereference]
>
> 5805                f = x_any_window_to_frame (dpyinfo, event.xclient.window);
>
> Event dereference: Dereferencing NULL value "f"
> Also see events: [returned_null][var_assigned]
>
> 5806                _XEditResCheckMessages (f->output_data.x->widget, NULL,
> 5807                                        &event, NULL);
> 5808                goto done;
> 5809              }
>
>