Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog

[Michaël Cadilhac]

Stefan Monnier <address@hidden> writes:

>>   When I do C-x C-f /a/b/c, with shell being /bin/sh (zsh emuled),
>>   I still have a weird behavior:
>
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, 
>> /a*/b*/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, 
>> /a**/b**/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, 
>> /a***/b***/
>> <TAB>
>> read-file-name-internal: Opening directory: no such file or directory, 
>> /a****/b****/
>
>>   AFAIU, this patch fixes the /c* bug (i.e. the last part of the filename
>>   being completed) but not the whole problem.
>
> Hmm... I remember working on such a bug report a few months ago.
> Can't remember whether I had fixed it at the time and if so how.  But in any
> case, I can't reproduce the problem right now.

  My bad, I recompiled a freshly checkouted Emacs and it works almost
  right.

  When I do C-x C-f /a/b/c TAB, no star are added, but an _error_ is
  triggered instead of a [no match].

  IMHO, it's due  to file_name_completion, and I'd be  very tempted to
  make the following:

Index: src/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/src/ChangeLog,v
retrieving revision 1.5083
diff -c -r1.5083 ChangeLog
*** src/ChangeLog       23 May 2006 08:12:13 -0000      1.5083
--- src/ChangeLog       23 May 2006 17:13:37 -0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2006-05-23  Michaël Cadilhac  <address@hidden>
+ 
+       * dired.c (file_name_completion): Don't barf if the base directory
+       can't be opened.
+ 
  2006-05-23  YAMAMOTO Mitsuharu  <address@hidden>
  
        * macterm.c (fn_keycode_to_xkeysym_table, convert_fn_keycode): Remove.
Index: src/dired.c
===================================================================
RCS file: /sources/emacs/emacs/src/dired.c,v
retrieving revision 1.122
diff -c -r1.122 dired.c
*** src/dired.c 6 Feb 2006 15:23:20 -0000       1.122
--- src/dired.c 23 May 2006 17:13:37 -0000
***************
*** 503,509 ****
  
        d = opendir (SDATA (Fdirectory_file_name (encoded_dir)));
        if (!d)
!       report_file_error ("Opening directory", Fcons (dirname, Qnil));
  
        record_unwind_protect (directory_files_internal_unwind,
                               make_save_value (d, 0));
--- 503,509 ----
  
        d = opendir (SDATA (Fdirectory_file_name (encoded_dir)));
        if (!d)
!       break;
  
        record_unwind_protect (directory_files_internal_unwind,
                               make_save_value (d, 0));

  It works if I do so, but I don't know if I'm not breaking another
  functionality.

  So ?

-- 
 |      Michaël `Micha' Cadilhac   |   Would someone please DTRT with this  |
 |         Epita/LRDE Promo 2007   |         then ACK?                      |
 | http://www.lrde.org/~cadilh_m   |           -- Richard Stallman          |
 `--  -   JID: address@hidden --'                                   -  --'

pgpPVALRImvHX.pgp
Description: PGP signature