emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: asm-mode patch to allow per-file comment character setting from file


From: Stefan Monnier
Subject: Re: asm-mode patch to allow per-file comment character setting from file locals
Date: Sun, 11 Jun 2006 17:20:17 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

I don't have time to look in detail at the patch, but here are some comments:

> +(make-variable-buffer-local 'asm-comment-char)

Please don't do that.  USe make-local-variable where necessary instead.

> +(put 'asm-comment-char 'safe-local-variable t)

Use an actual function instead rather than just t.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]