Re: Minimal patch: Use link face as default for button face

[Lennart Borgman]

Eli Zaretskii wrote:
> > Date: Sun, 25 Jun 2006 10:09:22 +0200
> > From: Lennart Borgman <address@hidden>
> >
> > Now that there is a face called 'link should not this be used in button.el?
> >
> >
> > diff -u -r1.21 button.el
> > --- button.el   6 Feb 2006 14:33:32 -0000       1.21
> > +++ button.el   25 Jun 2006 08:07:32 -0000
> > @@ -52,9 +52,8 @@
> >  ;; Globals
> >
> >  ;; Use color for the MS-DOS port because it doesn't support underline.
> > -(defface button '((((type pc) (class color))
> > -                  (:foreground "lightblue"))
> > -                 (t :underline t))
> > +(defface button
> > +  '((t :inherit link))
> >    "Default face used for buttons."
> >    :group 'basic-faces)
> >     
>
> This modifies the face default for (type pc).  I don't think it's
> time to change defaults now.
>   
Would it not be better then to move this default to the face "link"? 
What is the benefit of not doing this now?