Re: address@hidden: keys are sometimes not removed from pgg's password cache]

[Daiki Ueno]

>>>>> In <address@hidden> 
>>>>>   Richard Stallman <address@hidden> wrote:
> Would someone please fix this and ack?

> ------- Start of forwarded message -------
> To: address@hidden
> From: address@hidden (Andreas =?iso-8859-1?Q?V=F6gele?=)
> Date: Sat, 15 Jul 2006 21:31:39 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=us-ascii
> Cc: address@hidden
> Subject: keys are sometimes not removed from pgg's password cache
> X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
>       version=3.0.4

> According to pgg.el "keys are truncated to 8 trailing characters
> unless NOTRUNCATE is true".  But actually the macro
> pgp-truncate-key-identifier in pgg-def.el doesn't truncate keys.
> Instead the first eight characters are removed from the key:

> (pgg-truncate-key-identifier "xxxxxxxx123456789")
> ; -> "123456789"

> The macro is defined as follows:

> (defmacro pgg-truncate-key-identifier (key)
>   `(if (> (length ,key) 8) (substring ,key 8) ,key))

> I think the second argument to substring should be -8 instead
> of 8:

> (defmacro pgg-truncate-key-identifier (key)
>   `(if (> (length ,key) 8) (substring ,key -8) ,key))

> I don't know why keys mustn't be longer than 8 characters.  But the
> fix above solved my problem.

I probably recalled the intent of that function; it is used to truncate
the long key ID (i.e. fingerprint) to the last 8 letters.

The above fix is reasonable.  I just installed the following patch in
Gnus.  Could someone install it to Emacs?

2006-07-24  Daiki Ueno  <address@hidden>

        * pgg-def.el (pgg-truncate-key-identifier): Truncate the key ID to 8
        letters from the end.  Thanks to "David Smith" <address@hidden> and
        address@hidden (Andreas Vögele)

--- pgg-def.el  9 Feb 2006 05:47:53 -0000       7.10
+++ pgg-def.el  24 Jul 2006 00:54:44 -0000      7.11
@@ -87,7 +87,7 @@
   "If t, inform the recipient that the input is text.")
 
 (defmacro pgg-truncate-key-identifier (key)
-  `(if (> (length ,key) 8) (substring ,key 8) ,key))
+  `(if (> (length ,key) 8) (substring ,key -8) ,key))
 
 (provide 'pgg-def)

Regards,
-- 
Daiki Ueno