emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: a bug of read-passwd


From: Chong Yidong
Subject: Re: a bug of read-passwd
Date: Wed, 26 Jul 2006 14:33:25 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

> read_char needs to do arithmetic so it can recompute the remaining
> timeout, in case wait_reading_process_output returned an event
> which got discarded.  But this is not very hard.  Just add the
> specified timeout to the current time, at the start, and subtract
> the current time before each call to wait_reading_process_output.
>
> wait_reading_process_output does this same computation in order
> to call select with the proper remaining timeout.
>
> The inelegance of this is just a matter of repeating a little code.
> At the deeper level, this design is elegant because it is very safe.
> So I think we should try it.

I've checked in changes that implement this.  `read-event' and friends
now have an optional third argument that tells them how long to wait
for.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]