Re: whitespace-cleanup from /etc/TODO

[Adrian Aichner]

Yoni Rabkin Katzenell <address@hidden> writes:

> The following trivial patch will print an appropriate message when
> `whitespace-cleanup' is run on a region, otherwise it will print that
> `whitespace-cleanup' has run on the entire buffer.
>
> diff -c /home/yrk/devel/sandbox/emacs-hacking/whitespace-original.el 
> /home/yrk/devel/sandbox/emacs-hacking/whitespace.el
> *** /home/yrk/devel/sandbox/emacs-hacking/whitespace-original.el      
> 2006-08-13 21:23:58.542642560 +0300
> --- /home/yrk/devel/sandbox/emacs-hacking/whitespace.el       2006-08-13 
> 21:12:38.085087832 +0300
> ***************
> --- 575,586 ----
>       ;; Call this recursively till everything is taken care of
>       (if whitespace-any
>           (whitespace-cleanup-internal)
> +       ;; if we are done, talk to the user
>         (progn
> !         (unless whitespace-silent
> !           (if whitespace-region-only
> !               (message "The region is now clean")

I suggest to retain the buffer-file-name argument in the case above.

Otherwise you're trading an old piece of valuable information against
a new (perhaps less important) one.

Adrian

> !             (message "%s is now clean" buffer-file-name)))
>           (whitespace-update-modeline)))
>       (setq tab-width whitespace-tabwith-saved))))
>   

-- 
Adrian Aichner
 mailto:address@hidden
 http://www.xemacs.org/