[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] fix for the gcc -O3 miscompilation
|
From: |
Andreas Schwab |
|
Subject: |
Re: [patch] fix for the gcc -O3 miscompilation |
|
Date: |
Mon, 21 Aug 2006 10:56:13 +0200 |
|
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
Jindrich Makovicka <address@hidden> writes:
> the attached patch fixes the long standing breakage when compiling
> emacs with newer gcc and -O3 flag. The problem is that -O3 enables
> automatic function inlining, which optimizes out the arguments for
> the function invocations within eval.c and fns.c, but the functions
> expect these values on stack. Adding the "noinline" attribute to these
> functions used within eval.c of fns.c seems to solve the problem.
IMHO it would be much cleaner to define NO_ARG_ARRAY for all
configurations (effectively removing the option).
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."