Re: Broken sit-for

[Kim F. Storm]

David Kastrup <address@hidden> writes:

> address@hidden (Kim F. Storm) writes:
>
>> address@hidden (Kim F. Storm) writes:
>>
>>> I agree that (sit-for 0) should return nil if input is pending on entry.
>>
>> Are there any objections to installing the version of sit-for below:
>
> [...]
>
>> Value is t if waited the full time with no input arriving, and nil otherwise.
>
>>     (sleep-for seconds)
>>     t)
>>    ((input-pending-p)
>>     nil)
>>    ((<= seconds 0)
>>     (or nodisp (redisplay)))
>
> The doc string for "redisplay" does not specify a return value, 

I have fixed that.

>
>>    (t
>>     (or nodisp (redisplay))
>>     (let ((read (read-event nil nil seconds)))
>>       (or (null read)
>>        (progn (push read unread-command-events) nil))))))
>
> This does not interfere with the myriad of other
> unread-command-events like variables we have?  They are sure to be
> unused at this point of time?

It does (but that's how the code looks now).

Perhaps it should simply use unread-post-input-method-events instead
of unread-command-events.

-- 
Kim F. Storm <address@hidden> http://www.cua.dk