Re: GNU Emacs no longer honours top and left parameters to make-frame

[Ralf Angeli]

* YAMAMOTO Mitsuharu (2006-09-22) writes:

>>>>>> On Thu, 21 Sep 2006 22:30:47 +0200, Ralf Angeli <address@hidden> said:
>
>> Does anybody know if there is another variable where the (top and
>> left) values given to `make-frame' are stored and which could be
>> used by w32_createwindow to look them up?
>
> f->top_pos and f->left_pos, which are set in x_figure_window_size.
>
> As I said in 
> http://lists.gnu.org/archive/html/emacs-devel/2006-07/msg01367.html,
> whether we should honor these variables has something to do with size
> hints.  Maybe you can simply check f->size_hint_flags, which is also
> set in x_figure_window_size, against USPosition and PPosition to
> decide that.

Thanks for the hint.  The attached patch checks the value of
f->size_hint_flags in order to decide if the f->left_pos and
f->top_pos values should be used.

With the patch applied stuff like (make-frame '((top . 10))) works
now.  The only drawback is that the value of f->size_hint_flags does
not allow to determine if both top and left positions or only one is
set.  That means in case of the make-frame call above, for example,
the frame is horizontally positioned at the left edge of the desktop,
as the default value for f->left_pos is 0.

Here is a change log entry:

2006-10-07  Ralf Angeli  <address@hidden>

        * w32fns.c (w32_createwindow): Honour left and top positions if
        supplied explicitely.

-- 
Ralf

w32fns.patch
Description: Text Data