emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} do


From: Andreas Schwab
Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
Date: Thu, 12 Oct 2006 14:47:34 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux)

Giorgos Keramidas <address@hidden> writes:

> It seems to include this part:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       else true; fi
>
> We don't really *need* to have an else branch in all statements.  We can
> write this as:
>
> +       if [ ! -d ${INSTALLDIR} ] ; then \
> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
> +       fi

Except that some old shells will cause the whole command to fail if the
condition fails.

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]