emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor src/xmenu.c change for older GCC versions


From: Giorgos Keramidas
Subject: Re: Minor src/xmenu.c change for older GCC versions
Date: Sun, 5 Nov 2006 15:18:08 +0200

On 2006-11-05 14:06, Eli Zaretskii <address@hidden> wrote:
>>Date: Sun, 5 Nov 2006 10:00:57 +0200
>>From: Giorgos Keramidas <address@hidden>
>>Cc: Chong Yidong <address@hidden>, address@hidden
>>>
>>> Please add a comment explaining why this is necessary, to make sure
>>> people don't take this out for elegance's sake.
>>
>> Good point.  Sorry I didn't add a comment originally.  I thought
>> mentioning it in the commit log would be sufficient for now :)
>
> It's actually the other way around: the ChangeLog entry should only
> tell WHAT has been changed; the WHY should be in the comments to the
> code.  See the GNU coding standards for more about this.

I see.

I've worked mostly with FreeBSD sources, where follow the reverse
principle.  The commit logs keep the WHY of each change there.

I'll have to reread the GNU coding standards.

Thanks for the explanation :)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]