Re: Incorrect declarations of thread functions on w32

[Lennart Borgman]

Jason Rumney wrote:
> Lennart Borgman wrote:
> > I thought I had given enough information when saying this. In the 
> > message before I told how the declaration should look according to MS. 
> > w32_msg_worker should have a declaration that looks like
> >
> > DWORD WINAPI ThreadProc(
> >   LPVOID lpParameter
> > );
> >
> > where ThreadProc should be replaced with w32_msg_worker. The same for 
> > reader_thread.
> reader thread already has that signature.
>
> > Perhaps the declarations boils down to correct declarations under some 
> > circumstances
> > , but I believe they should be changed since errors that bad 
> > declarations produce might be very hard to find. (Memory corruption etc.)
>
> In the case of reader_thread, it is the correct declaration in all 
> circumstances under Win32 (not under Win16, but Emacs does not target 
> that platform)

Seems like reader_thread is ok, but would it not be much easier to 
understand if LPVOID was used instead of void* in the argument?

But w32_msg_worker needs some fix. I would suggest using exactly the 
type declarations from above. It makes it much easier to read the code 
if nothing else.