Re: How global is a define-global-minor-mode mode?

[Lennart Borgman (gmail)]

Stefan Monnier wrote:
> > > > > Isn't it the case that it works if the minor mode function
> > > > > corresponding to the variable is autoloaded?  Otherwise, IIRC you need
> > > > > to add a :require to the definition of the minor mode.
> > > > Not really: if the global minor mode is autoloaded, then :require is
> > > > a nuisance,
> > > > I don't follow.  Could you explain why it is a nuisance?
> > > The :require thingy is a risk: if you move the definition of the mode to
> > > another file, then the user's customizations will be broken (it happened
> > > with global-font-lock-mode).
>
> > I have lost my way here, but I did some tests to try to understand. If I use
> > defcustom with a :set function this will be called when the elisp file is
> > loaded. Why can't something similar be done for define-global-minor-mode
> > also? It is a global mode and then :set is passed to defcustom, or?
>
> I don't understand your question.  What do you suggest exactly and for
> what purpose?

I previously used defcustom variables to manage something similar to 
define-globalized-mode MY-GLOBAL-MODE MY-MODE. This worked ok. I then 
used the :set function to  turn on the minor mode MY-MODE.

Using define-minor-mode there is no way to do something similar. There 
is no code that is run when the library file is loaded, even if the 
minor mode is global and that is in my opinion a bug (or at least a very 
inconvenient inconsistency).

Actually define-minor-mode says that "other keywords will be passed to 
defcustom if the minor mode is global". Should not this mean that :set 
should be passed to defcustom and therefore be run when loading the 
library file if the minor mode as been customized to be on? I can not 
see that :set is run however.

On the other hand one may wonder why not the body or the hook of the 
minor mode is run when loading the library. I can see the purpose of 
this (that you should be able to load a library without running any 
code), but there are a few inconsistenceis here (compared with 
defcustom). I think this inconsistencies should be addressed before 
trying to fix define-globalized-minor-mode. But I am quite a bit unsure 
about how to handle the problem with body/hook/:set for a define-minor-mode.

Below are some test code I have used in my own library. This code should 
give some messages when loading the library they are put in. Please test 
it with the defcustom and define-minor-mode set.


(defvar html-site-temp-mode-hook nil)
(add-hook 'html-site-temp-mode-hook
          (lambda()
            (message "html-site-temp-mode-hook, html-site-temp-mode=%s" 
html-site-temp-mode)))

(define-minor-mode html-site-temp-mode
  "dummy"
  :init-value nil
  :lighter nil
  :global t
  :keymap (let ((m (make-sparse-keymap)))
            (define-key m [f11] (lambda() (interactive) (message 
"html-site-mode-temp f11 here")))
            m)
  :set (lambda(sym val)
         (message ":set html-site-temp-mode: sym=%s, val=%s" sym val)
         (set-default sym val))
  (message "body html-site-temp-mode=%s, current-buffer=%s" 
html-site-mode (current-buffer)))

(defcustom html-site-temp nil
  "doc"
  :type 'boolean
  :set (lambda(sym val)
         (message ":set html-site-temp: sym=%s, val=%s" sym val)
         (set-default sym val)))

(message "html-site.el loaded, html-site-global-mode=%s, 
html-site-temp=%s, html-site-temp-mode=%s"
         html-site-global-mode
         html-site-temp
         html-site-temp-mode
         )


> > BTW should not the name be define-globalized-minor-mode as was
> > suggested before?
>
> I believe so, yes.  Feel free to implement this change,
>
>
>         Stefan

As I use to say: I do not want to touch the CVS this close to the 
release since I am unfamiliar with cvs. I would be glad if you changed 
the name.