Re: Pathnames with two (or more) slashes in Makefile.c

[Sascha Wilde]

Jan Djärv <address@hidden> wrote:

> Sascha Wilde skrev:
>> Jan Djärv <address@hidden> wrote:
[...]
>> So the problem is, that the double slash is written unquoted to
>> Makefile.c where it gets interpreted as a comment.
>>
>> This is IMO a bug.
>>
>> When generating Makefile.c consecutive slashes hould either be reduced
>> to one or appropriately quoted.
>
> Actually it was a bug in my patch, I should not use #define if a
> double slash may be present.  I briefly checked the other #define:s in
> Makefile.in and mostly the valuse comes from s/*.h or m/*.h, so we
> have control over these.
>
> I've checked in a fix, please try it.

Sorry, maybe I'm seriously missing something here, but I can't see
such a change by you, neither in CVS nor in the ChangeLog.

And, build still fails...  :-(

FWIW: my workaround for now looks like this:

--- a/configure.in
+++ b/configure.in
@@ -3256,6 +3256,7 @@
       < Makefile.c > junk1.c
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+      -e 's,\(#.*\)//\+,\1/,g' \
       < Makefile.c > junk.c
   $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /    /' -e '/^#/d' -e '/^[   ]*$/d' > junk2.c
@@ -3272,6 +3273,7 @@
       < Makefile.c > junk1.c
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
+      -e 's,\(#.*\)//\+,\1/,g' \
       < Makefile.c > junk.c
   $CPP $undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /    /' -e '/^#/d' -e '/^[   ]*$/d' > junk2.c

cheers
sascha
-- 
Sascha Wilde   -.-. ..- .-. .. --- ... .. - -.-- 
               -.- .. .-.. .-.. . -.. 
               - .... .
               -.-. .- -