emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: More visible mini-buffer prompt face


From: Lennart Borgman (gmail)
Subject: Re: More visible mini-buffer prompt face
Date: Sat, 24 Feb 2007 02:35:51 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666

Richard Stallman wrote:
I wonder if it would not be better to have a more visible face for the minibuffer prompt by default. My suggestion would be using a visible background color (some not too sharp yellow perhaps).

What color do you get now?

Dark blue text on white.

Which of the options in the defface is being used?
Could you propose a patch in that defface?

The face used is minibuffer-prompt, see below. I have made a new suggestion for the default. This is modelled after secondary-selection face to avoid to big surprises. For light background this face has a yellow background. AFAIU yellow is often used to draw attention on different signs in our culture and that makes it a good choice here.

I selected a somewhat darker yellow variant of the named colors which I personally find more pleasant. Though I do not know if this color fits the (min-colors 88).

However it does not seem that the support for my idea is very big at the moment ;-)


Index: faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.366
diff -u -r1.366 faces.el
--- faces.el    14 Feb 2007 15:31:09 -0000      1.366
+++ faces.el    23 Feb 2007 20:14:56 -0000
@@ -2134,12 +2134,20 @@
   :version "22.1"
   :group 'basic-faces)

+;; Modelled after secondary-selection face.
+;; Suggested on Emacs Devel as usual.
 (defface minibuffer-prompt
-  '((((background dark)) :foreground "cyan")
-    ;; Don't use blue because many users of the MS-DOS port customize
-    ;; their foreground color to be blue.
-    (((type pc)) :foreground "magenta")
-    (t :foreground "dark blue"))
+  '((((class color) (min-colors 88) (background light))
+     :background "gold")
+    (((class color) (min-colors 88) (background dark))
+     :background "SkyBlue4")
+    (((class color) (min-colors 16) (background light))
+     :background "yellow")
+    (((class color) (min-colors 16) (background dark))
+     :background "SkyBlue4")
+    (((class color) (min-colors 8))
+     :background "cyan" :foreground "black")
+    (t :inverse-video t))
   "Face for minibuffer prompts.
 By default, Emacs automatically adds this face to the value of
 `minibuffer-prompt-properties', which is a list of text properties




reply via email to

[Prev in Thread] Current Thread [Next in Thread]