Re: `key-binding' and XEmacs-style events

[Stuart D. Herring]

>>     We're talking about going the other way -- supporting
>>     (key-binding [(?a)]) in Emacs (I don't know what XEmacs thinks
>>     of event-lists with no modifiers).  The simplest fix seems to be
>>     to move the check that the list is at least two long before the
>>     code that uses its first element as a symbol:
>>
>> Would someone please install your patch?
>
> Done, but I am not sure that we have all the documentation in place
> that would have made it possible to avoid programming this bug in the
> first place.
>
> And I am utterly unsure that this will cover all cases of some
> XEmacs-style sequences possibly being confused with events.

Thanks, David!  I forgot to include a ChangeLog entry, since I didn't know
the patch would just go in as it was; the one you supplied has an
off-by-one error, which the following patch fixes.

*** ChangeLog.~1.5584.~ 2007-03-06 09:58:24.000000000 -0700
--- ChangeLog   2007-03-06 10:03:57.000000000 -0700
***************
*** 29,35 ****

  2007-03-02  Stuart D. Herring <address@hidden>

!       * keymap.c (Fkey_binding): Don't consider two-element lists as
        events.

  2007-03-01  Kenichi Handa  <address@hidden>
--- 29,35 ----

  2007-03-02  Stuart D. Herring <address@hidden>

!       * keymap.c (Fkey_binding): Don't consider one-element lists as
        events.

  2007-03-01  Kenichi Handa  <address@hidden>

Thanks again,
Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.