emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

report-emacs-bug and *mail* buffer.


From: Michaël Cadilhac
Subject: report-emacs-bug and *mail* buffer.
Date: Wed, 07 Mar 2007 15:36:10 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux)

Hi!

I use both Gnus and report-emacs-bug, and I have a little problem :
Test case:

Create a new mail with Gnus with `m'. The buffer is called `*mail*'.
Now use M-x report-emacs-bug : your Gnus mail is converted to
mail-mode and asked for deletion. Even if you say no to deletion, the
buffer is converted to mail-mode, but if you really want to make a bug
report, you can't until you've close your Gnus *mail*.

I propose the following patch that forces, in the default config, to
use a new buffer each time r-e-bug is called. This is the simplest
change I could came up with ; others include searching for a bug-report
buffer and ask for its deletion, but the modifications are bigger.

Index: lisp/mail/emacsbug.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/mail/emacsbug.el,v
retrieving revision 1.72
diff -B -w -c -r1.72 emacsbug.el
*** lisp/mail/emacsbug.el       21 Jan 2007 02:59:07 -0000      1.72
--- lisp/mail/emacsbug.el       7 Mar 2007 13:32:56 -0000
***************
*** 89,95 ****
          (with-current-buffer (get-buffer-create "*Messages*")
            (point-max-marker)))
      (compose-mail reporting-address
!                 topic)
      ;; The rest of this does not execute
      ;; if the user was asked to confirm and said no.
      (rfc822-goto-eoh)
--- 89,95 ----
          (with-current-buffer (get-buffer-create "*Messages*")
            (point-max-marker)))
      (compose-mail reporting-address
!                 topic nil 'new)
      ;; The rest of this does not execute
      ;; if the user was asked to confirm and said no.
      (rfc822-goto-eoh)
Index: lisp/simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.848
diff -B -w -c -r1.848 simple.el
*** lisp/simple.el      6 Mar 2007 02:18:05 -0000       1.848
--- lisp/simple.el      7 Mar 2007 13:32:59 -0000
***************
*** 4668,4679 ****
  (defun sendmail-user-agent-compose (&optional to subject other-headers 
continue
                                              switch-function yank-action
                                              send-actions)
!   (if switch-function
!       (let ((special-display-buffer-names nil)
!           (special-display-regexps nil)
!           (same-window-buffer-names nil)
!           (same-window-regexps nil))
!       (funcall switch-function "*mail*")))
    (let ((cc (cdr (assoc-string "cc" other-headers t)))
        (in-reply-to (cdr (assoc-string "in-reply-to" other-headers t)))
        (body (cdr (assoc-string "body" other-headers t))))
--- 4668,4674 ----
  (defun sendmail-user-agent-compose (&optional to subject other-headers 
continue
                                              switch-function yank-action
                                              send-actions)
!   ;; `switch-function' is ignored as `mail' will choose its own buffer.
    (let ((cc (cdr (assoc-string "cc" other-headers t)))
        (in-reply-to (cdr (assoc-string "in-reply-to" other-headers t)))
        (body (cdr (assoc-string "body" other-headers t))))
Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.10783
diff -C0 -r1.10783 ChangeLog
*** lisp/ChangeLog      7 Mar 2007 12:50:23 -0000       1.10783
--- lisp/ChangeLog      7 Mar 2007 13:33:29 -0000
***************
*** 0 ****
--- 1,8 ----
+ 2007-03-07  Michaël Cadilhac  <address@hidden>
+ 
+       * simple.el (sendmail-user-agent-compose): Don't consider
+       `switch-function' as `mail' selects its own buffer.
+ 
+       * mail/emacsbug.el (report-emacs-bug): Suggest to use a new
+       mail buffer to `compose-mail'.
+ 
TIA.

-- 
 |   Michaël `Micha' Cadilhac       |  Libertude,                            |
 |   http://michael.cadilhac.name   |        Égalitude,                      |
 |   JID/MSN:                       |             Fraternitude.              |
 `----  address@hidden  |          -- À peu près S.R.       -  --'

Attachment: pgpzIJkqKwIV5.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]