emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DIFFS] Re: Connection to emacs CVS broken ?


From: Kim F. Storm
Subject: Re: [DIFFS] Re: Connection to emacs CVS broken ?
Date: Sun, 18 Mar 2007 00:52:02 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.95 (gnu/linux)

Chong Yidong <address@hidden> writes:

> HEAD is now up to date, 

Thank you very much.
I have verified that it matches the check-out I have from just before the
crash with two exceptions: dired.c and lisp-mode.el.

>                         with the exception of the very latest dired.c
> change (I couldn't find a ChangeLog entry or emacs-diffs commit log,
> so I'm not sure if that commit was completed before the crash).

I suspect RMS forgot to commit the changelog, but in any case I've installed
the dired.c change and added a ChangeLog entry for it.

There's also a change to lisp-mode.el which looks a bit odd:

*** ../latest/lisp/emacs-lisp/lisp-mode.el      2007-03-15 23:55:05.000000000 
+0100
--- lisp/emacs-lisp/lisp-mode.el        2007-03-13 14:37:51.000000000 +0100
***************
*** 96,102 ****
                             (regexp-opt
                              '("defun" "defun*" "defsubst" "defmacro"
                                "defadvice" "define-skeleton"
!                               "define-minor-mode" "define-global-minor-mode"
                                "define-globalized-minor-mode"
                                "define-derived-mode" "define-generic-mode"
                                "define-compiler-macro" "define-modify-macro"
--- 96,102 ----
                             (regexp-opt
                              '("defun" "defun*" "defsubst" "defmacro"
                                "defadvice" "define-skeleton"
!                               "define-minor-mode" 
"define-globalized-minor-mode"
                                "define-globalized-minor-mode"
                                "define-derived-mode" "define-generic-mode"
                                "define-compiler-macro" "define-modify-macro"


It looks plain wrong (it replaces define-global-minor-mode with
define-globalized-minor-mode which is already in the list) - so
I don't know what that change is supposed to fix.  But there was
this recent bug-report which might be related:

> From: "Lennart Borgman (gmail)" <address@hidden>
> Subject: define-globalized-minor-mode is not fontified as a keyword
> To: address@hidden
> Date: Mon, 12 Mar 2007 19:14:37 +0100
>  
> ... but define-global-minor-mode is in emacs-lisp-mode.
>  
>  
> In GNU Emacs 22.0.95.1 (i386-mingw-nt5.1.2600)
>  of 2007-03-08

to which RMS responded:

> From: Richard Stallman <address@hidden>
> Subject: Re: define-globalized-minor-mode is not fontified as a keyword
> Date: Mon, 12 Mar 2007 22:44:49 -0400
>  
> Thanks.


--
Kim F. Storm <address@hidden> http://www.cua.dk





reply via email to

[Prev in Thread] Current Thread [Next in Thread]